eolivelli commented on code in PR #3451:
URL: https://github.com/apache/bookkeeper/pull/3451#discussion_r950660562
##########
.asf.yaml:
##########
@@ -63,7 +63,7 @@ github:
required_pull_request_reviews:
dismiss_stale_reviews: false
require_code_owner_reviews: true
- required_approving_review_count: 1
+ required_approving_review_count: 2
Review Comment:
This is wrong.
Otherwise committers won't be able to commit their own patches with only one
approval from another committer.
The rule is that you need two +1 from people with committer karma.
So if a committer sends a patch,he needs only 1 binding +1
@StevenLuMT @zymap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
