michaeljmarshall opened a new pull request, #3482: URL: https://github.com/apache/bookkeeper/pull/3482
Fixes: https://github.com/apache/bookkeeper/issues/2945 ### Motivation When a read request is rejected due to the limit on the number of reads that can be enqueued, we need to decrement the metric for `bookkeeper_server_READ_ENTRY_IN_PROGRESS` and release the `readsSemaphore`, if it is not null. ### Changes * Call `onReadRequestFinish()` for failures in the V2 and V3 request processing logic. ### Observation It looks like the V2 responses for this kind of failure are not throttled, even when `throttleReadResponses` is true. We could call `read.sendReadReqResponse(` to enable this throttling. I didn't change it here because there might be a reason we're not throttling these small responses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
