wenbingshen commented on PR #3495: URL: https://github.com/apache/bookkeeper/pull/3495#issuecomment-1252695704
@StevenLuMT Thanks for your review. > 1. what scenarios are these two enumeration values of registrationSessionExpiredPolicy suitable for? This PR tends to introduce two policies `reconnect, shutdown` and keeps the same logic as before `reconnect`. It is found from the current unit testing and actual use, we should tend to use the `shutdown` policy. But I'm leaning towards this PR to keep the default `reconnect` policy and instead change to `shutdown` policy in #3418 to fix falky-test. Because Bookie is difficult to recover from Session Expired, as described in the comment: https://github.com/apache/bookkeeper/issues/3250#issuecomment-1190996890 So the reconnect policy is still a policy to be implemented and verified. `reconnect` was introduced to keep the same logic as before. We can use another PR to implement the complete policy of `Bookie Reconnect Recovery` from Session Expired. Here I divide it into three steps: 1. This PR introduces two policy options 2. Change the default policy to `shutdown` to solve flaky-test #3418 3. Implement complete bookie recovery logic for the `reconnect` policy > 2. please set two testcases for different enumerations to cover different logic I can introduce a test for `shutdown` Policy, and `reconnect` can reuse the previous `testBookieServerZKSessionExpireBehaviour` test, because `reconnect` is still an unstable recovery policy that can only be verified until the third point mentioned above is implemented: 3. Implement complete bookie recovery logic for the `reconnect` policy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
