massakam commented on PR #3214: URL: https://github.com/apache/bookkeeper/pull/3214#issuecomment-1253559671
@dlg99 > This gist https://gist.github.com/dlg99/505849e1010a20c6d439ecd53f500a85 is more of a demo of what's going on than actual fix (after all, it breaks `testShouldGetTwoFrgamentsIfTwoBookiesFailedInSameEnsemble` - might be a test issue). I have a question about this gist. Why is `releasePermit()` added on line 79 of LedgerChecker.java? https://gist.github.com/dlg99/505849e1010a20c6d439ecd53f500a85#file-pr3214-diff-L79 `EntryExistsCallback#readEntryComplete` also calls `releasePermit()`, so it seems that one extra permit is released. https://github.com/apache/bookkeeper/blob/7004d994938e914561d8343a96d9d75ce98b2837/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerChecker.java#L321 And if `releasePermit()` on line 75 of LedgerChecker.java is removed, `TestLedgerChecker` times out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
