hangc0276 commented on code in PR #3538:
URL: https://github.com/apache/bookkeeper/pull/3538#discussion_r996638179
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogMetadata.java:
##########
@@ -105,7 +106,7 @@ public void removeLedgerIf(LongPredicate predicate) {
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("{ totalSize = ").append(totalSize).append(", remainingSize
= ").append(remainingSize)
- .append(", ledgersMap = ").append(ledgersMap).append(" }");
+ .append(", ledgersMap =
").append(StringUtils.join(ledgersMap)).append(" }");
Review Comment:
We have overridden the `toString()` method for ledgersMap. Do we need to add
`join` for this map?
https://github.com/apache/bookkeeper/blob/cbb74eab4f1f464c0e4760acf9304af2289acfa1/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongHashMap.java#L914-L927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
