Ghatage opened a new pull request, #3543: URL: https://github.com/apache/bookkeeper/pull/3543
Descriptions of the changes in this PR: ### Motivation Codahale metrics are used for dashboarding with Grafana and we must rely on these values to be accurate in order to measure the stability and performance of the service. For Codahale's fast timer, when a value falls in the last bucket, the max is reported as the upper bound of the last bucket (Long.MAX_VALUE) which can lead to erroneous 99 percentile values. ### Changes We change the way we get the max value recorded if the bucket we're dealing with is the last bucket (for 99th percentile). If we are in the last bucket, we return the actual max, otherwise we can return `getBucketBound()` which should return the accurate calculated value. Also added a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
