[bookkeeper] branch master updated: fix close ledgerAuditorManager repeatedly (#3503)

[yong]

This is an automated email from the ASF dual-hosted git repository.

yong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new dbec4e91ec fix close ledgerAuditorManager repeatedly (#3503)
dbec4e91ec is described below

commit dbec4e91eca20566a4db1673e9db1d728f659960
Author: wenbingshen <oliver.shen...@gmail.com>
AuthorDate: Wed Oct 19 14:30:48 2022 +0800

    fix close ledgerAuditorManager repeatedly (#3503)
    
    ### Motivation
    this introduced in #2842, the `ledgerAuditorManager` will be close 
repeatedly.
    
    ```java
        private void submitShutdownTask() {
            executor.submit(new Runnable() {
                    @Override
                    public void run() {
                        if (!running.compareAndSet(true, false)) {
                            return;
                        }
    
                        try {
                            ledgerAuditorManager.close();   <- here has already 
closed LAM.
                        } catch (InterruptedException ie) {
                            Thread.currentThread().interrupt();
                            LOG.warn("InterruptedException while closing ledger 
auditor manager", ie);
                        } catch (Exception ke) {
                            LOG.error("Exception while closing ledger auditor 
manager", ke);
                        }
                    }
                });
        }
    ```
---
 .../java/org/apache/bookkeeper/replication/AuditorElector.java     | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorElector.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorElector.java
index 0e58679b2f..e59065125e 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorElector.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorElector.java
@@ -231,16 +231,11 @@ public class AuditorElector {
      * Shutting down AuditorElector.
      */
     public void shutdown() throws InterruptedException {
-        try {
-            ledgerAuditorManager.close();
-        } catch (Exception e) {
-            throw new RuntimeException(e);
-        }
-
         synchronized (this) {
             if (executor.isShutdown()) {
                 return;
             }
+            // close auditor manager
             submitShutdownTask();
             executor.shutdown();
         }