gaozhangmin commented on code in PR #3548:
URL: https://github.com/apache/bookkeeper/pull/3548#discussion_r998992706
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java:
##########
@@ -86,6 +88,7 @@ public LedgerOpenOp(BookKeeper bk, BookKeeperClientStats
clientStats,
this.enableDigestAutodetection =
bk.getConf().getEnableDigestTypeAutodetection();
this.suggestedDigestType = digestType;
this.openOpLogger = clientStats.getOpenOpLogger();
+ this.scheduler =
OrderedScheduler.newSchedulerBuilder().numThreads(1).name("LedgerOpenOp").build();
Review Comment:
We cannot use executor in bk, if bk is closed unexpectedly, the operation
will never completed. @eolivelli
I tested before, some unit test would stuck forever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
