merlimat commented on code in PR #3560:
URL: https://github.com/apache/bookkeeper/pull/3560#discussion_r1002813842
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java:
##########
@@ -481,12 +482,14 @@ public ReferenceCounted retain(int increment) {
@Override
public ReferenceCounted touch() {
- return data.touch();
Review Comment:
When using the leak checker, this was causing the `ReadResponse` to get
converted into an instrumented buffer, and the serialization was completely
skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
