wenbingshen opened a new pull request, #3627:
URL: https://github.com/apache/bookkeeper/pull/3627

   ### Motivation
   
   testWriteLac recently became flaky-test: 
   
https://github.com/apache/bookkeeper/actions/runs/3424530676/jobs/5704307573#logs
   
   1. Before the entry added the journal entry queue, entry.retain() will be 
executed.
   2. So add a callback function to ensure that the entry is verified after the 
entry is executed done in the journal entry queue.
   
   
   ```java
       public void logAddEntry(long ledgerId, long entryId, ByteBuf entry,
                               boolean ackBeforeSync, WriteCallback cb, Object 
ctx)
               throws InterruptedException {
           // Retain entry until it gets written to journal
           entry.retain();
           ......
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to