nicoloboschi commented on code in PR #3643:
URL: https://github.com/apache/bookkeeper/pull/3643#discussion_r1022481779
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -3663,7 +3663,7 @@ public ServerConfiguration
setHttpServerTrustStorePath(String trustStorePath) {
* @return http server trustStore password
*/
public String getHttpServerTrustStorePassword() {
- return getString(HTTP_SERVER_KEY_STORE_PASSWORD);
+ return getString(HTTP_SERVER_TRUST_STORE_PASSWORD);
Review Comment:
should we handle retrocompatibility here? the risk is that the user upgrades
and the webserver doesn't work anymore
at least, we should add highlight in the release notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
