wenbingshen commented on code in PR #3646:
URL: https://github.com/apache/bookkeeper/pull/3646#discussion_r1022831077
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java:
##########
@@ -254,7 +254,7 @@ public void removeOffsetFromDeletedLedgers() throws
IOException {
++deletedEntries;
}
- if (deletedEntriesInBatch > DELETE_ENTRIES_BATCH_SIZE) {
+ if (deletedEntriesInBatch > deleteEntriesBatchSize) {
batch.flush();
batch.clear();
deletedEntriesInBatch = 0;
Review Comment:
```
Nov 11, 2022 @ 05:49:39.336 05:49:39.336 [db-storage-cleanup-10-1] INFO
org.apache.bookkeeper.bookie.storage.ldb.EntryLocationIndex - Deleted indexes
for 0 entries from 16074 ledgers in 625.242 seconds
```
`deletedEntries=0`, does it mean that the condition of
`deletedEntriesInBatch > DELETE_ENTRIES_BATCH_SIZE` has not entered yet, will
adjusting the size of `DELETE_ENTRIES_BATCH_SIZE` affect this delay? It doesn't
look like the read latency to a few seconds is caused by this situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
