wenbingshen commented on code in PR #3637:
URL: https://github.com/apache/bookkeeper/pull/3637#discussion_r1023458552
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java:
##########
@@ -587,7 +270,7 @@ synchronized Future<?> submitAuditTask() {
knownBookies.removeAll(bookiesToBeAudited);
if (lostBookieRecoveryDelay == 0) {
- startAudit(false);
+ newAuditorBookieCheckTask().startAudit(false);
Review Comment:
@hangc0276 May be we can use netty Recycler. But I don't think a large
number of AuditorTasks will be created in a short period of time, because the
inspection tasks are executed periodically, most of them are once a day, and
these instances can be recycled by the GC as soon as possible.
If you feel strongly about this, I can add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
