horizonzy commented on code in PR #3654:
URL: https://github.com/apache/bookkeeper/pull/3654#discussion_r1032017137
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java:
##########
@@ -1145,9 +1145,10 @@ public void replicateLedgerFragment(LedgerHandle lh,
final LedgerFragment ledger
if (MapUtils.isEmpty(targetBookieAddresses)) {
LOG.warn("Could not replicate for {} ledger: {}, not find target
bookie.",
ledgerFragment.getReplicateType(),
ledgerFragment.getLedgerId());
- return;
+ return false;
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]