dlg99 commented on issue #3711: URL: https://github.com/apache/bookkeeper/issues/3711#issuecomment-1364190994
> When trying to debug this in code found that condition is checking for meta.Usage > threshold and ignore the meta file which is supposed to get deleted, what I feel it should be checking the meta.Remaining > Threshold. meta.remaining is bytes. Threshold is a cutoff utilization (as percentage), meta.usage is meta.remainingSize / meta.totalSize. remainingSize is the size used by ledgers/entries that are live (not deleted). As the docs say, `For those entry log files whose remaining size **percentage** reaches below this threshold will be compacted` Let's say total size of the entry log is 1000 Mbytes, remainingSize is 750 Mbytes. So the usage is 0.75 In case threshold set to 0.6 the compaction won't be performed on this entry log because the usage > threshold. The logic there is the i/o is not free and rewrite of 750Mbytes to free up a bit of space will be a perf hit on the bookie. If the disk space is a concern and the perf is not, you can set the threshold higher (0.8 or so) and this log will be compacted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
