horizonzy commented on code in PR #3726:
URL: https://github.com/apache/bookkeeper/pull/3726#discussion_r1063216808
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java:
##########
@@ -1663,4 +1657,17 @@ public ByteBufAllocator getByteBufAllocator() {
public ClientContext getClientCtx() {
return clientCtx;
}
+
+ private void checkLedgerCreationParameters(int ensSize, int
writeQuorumSize, int ackQuorumSize) {
+ if (ensSize <= 0
+ || writeQuorumSize <= 0
+ || ackQuorumSize <= 0
Review Comment:
I check again, `ackRuorumSize == 0` is meaningless for us. The
`PendingAddOp#writeComplete` need to callback at least once. We didn't complete
the `PendingAddOp` when the `ackRuorumSize == 0`.
So keep it as it is
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java:
##########
@@ -1663,4 +1657,17 @@ public ByteBufAllocator getByteBufAllocator() {
public ClientContext getClientCtx() {
return clientCtx;
}
+
+ private void checkLedgerCreationParameters(int ensSize, int
writeQuorumSize, int ackQuorumSize) {
+ if (ensSize <= 0
+ || writeQuorumSize <= 0
+ || ackQuorumSize <= 0
Review Comment:
~I think `ackQuorumSize==0` is legal, which means no need ack; just write.~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
