wenbingshen opened a new pull request, #3736:
URL: https://github.com/apache/bookkeeper/pull/3736

   ### Motivation
   
   Related to PR #3522, in order to implement masterKeyCache to clean up the 
deleted ledgerId, PR #3522 introduced LedgerStorageNotificationListener, which 
is used to monitor the cleanup action of calling back masterKeyCache when the 
ledger is deleted. I noticed that before this, LedgerStorage already has The 
purpose of the implementation of LedgerDeletionListener is to call back the 
corresponding user to do some cleaning operations after the ledger is deleted, 
which fully meets the requirements of LedgerStorageNotificationListener.
   
   The function of the additionally introduced 
LedgerStorageNotificationListener is the same as that of 
LedgerDeletionListener, but a strange operation L is introduced in the GC 
thread: the GC thread needs to process a LedgerStorageNotificationListener 
notification, and the GC thread calls ledgerStorage.deleteLedger(ledgerId), and 
it will be executed  LedgerDeletionListener notification again during the 
processing deleteLedger.
   
   ### Changes
   
   Replace LedgerStorageNotificationListener with existing 
LedgerDeletionListener to achieve this requirement.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to