horizonzy commented on code in PR #3584:
URL: https://github.com/apache/bookkeeper/pull/3584#discussion_r1068929451
##########
conf/log4j2.xml:
##########
@@ -28,13 +28,13 @@
</Properties>
<Appenders>
<Console name="CONSOLE" target="SYSTEM_OUT">
- <PatternLayout pattern="%d{ISO8601} - %-5p - [%t:%C{1}@%L] -
%m%n"/>
+ <PatternLayout pattern="%d{ISO8601} - %-5p - [%t:%c{1}] - %m%n"/>
</Console>
<File name="TRACEFILE"
fileName="${sys:bookkeeper.log.dir}/bookkeeper-trace.log">
- <PatternLayout pattern="%d{ISO8601} - %-5p [%t:%C{1}@%L][%ndc] -
%m%n"/>
+ <PatternLayout pattern="%d{ISO8601} - %-5p [%t:%c{1}][%ndc] -
%m%n"/>
</File>
<RollingFile name="ROLLINGFILE"
fileName="${sys:bookkeeper.log.dir}/${sys:bookkeeper.log.file}"
filePattern="${sys:bookkeeper.log.dir}/${sys:bookkeeper.log.file}%d{.yyyy-MM-dd}">
- <PatternLayout pattern="%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n"/>
+ <PatternLayout pattern="%d{ISO8601} - %-5p [%t:%c{1}] - %m%n"/>
Review Comment:
Without `%L`, we can't identify the place where the log is from.
In some case, we will record the same info in the same class, without the
line number, we can't trace the problem precisely according to the log info.
If we want to remove `%L`, we should ensure can't print same log content in
the same class in different place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
