hangc0276 commented on PR #3738:
URL: https://github.com/apache/bookkeeper/pull/3738#issuecomment-1409583667
> > Overall LGTM. This change saves the cost of choosing threads in
executeOrdered, and I wonder if choosing threads costs a lot of CPU resources
and whether this change can improve the performance or not.
>
> I tested it using one bookie client to add entry async like following. It
looks that it was not a significant improvement from the result.
>
> ```
> for (int i = 0; i < Integer.MAX_VALUE; ++i) {
> handle.asyncAddEntry("Some entry data".getBytes(), new
AsyncCallback.AddCallback() {
> @Override
> public void addComplete(int rc, LedgerHandle lh, long
entryId, Object ctx) {
>
> }
> }, null);
> }
> ```
@AnonHxy If there is no significant performance improvement, I think we can
hold this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
