AnonHxy commented on PR #3758:
URL: https://github.com/apache/bookkeeper/pull/3758#issuecomment-1413062494
> @hangc0276 Should the following code also use ParsedAddRequest to judge?
for example: if (request instanceof BookieProtocol. ParsedAddRequest) {
requestProcessor.onAddRequestFinish(); }
>
>
https://github.com/apache/bookkeeper/blob/accaa6966f17cb9bf6c7d74de3deac49b758c01b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java#L178-L180
I think it looks like a bug that we shoud use `ParsedAddRequest`. Shall we
fix it in this PR or a new PR? WDYT @hangc0276 @lordcheng10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
