nicoloboschi commented on code in PR #3764:
URL: https://github.com/apache/bookkeeper/pull/3764#discussion_r1094429602
##########
stream/distributedlog/core/src/main/java/org/apache/distributedlog/impl/metadata/ZKLogStreamMetadataStore.java:
##########
@@ -269,10 +269,14 @@ public void processResult(final int rc, final String
path, Object ctx, String na
logMetadata.getFullyQualifiedName())));
} else if (KeeperException.Code.OK.intValue() == rc) {
FutureUtils.complete(promise, null);
- LOG.trace("Created path {}.", path);
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("Created path {}.", path);
+ }
} else if (KeeperException.Code.NODEEXISTS.intValue()
== rc) {
FutureUtils.complete(promise, null);
- LOG.trace("Path {} is already existed.", path);
+ if (LOG.isTraceEnabled()) {
Review Comment:
this is not useful
##########
stream/distributedlog/core/src/main/java/org/apache/distributedlog/impl/metadata/ZKLogStreamMetadataStore.java:
##########
@@ -269,10 +269,14 @@ public void processResult(final int rc, final String
path, Object ctx, String na
logMetadata.getFullyQualifiedName())));
} else if (KeeperException.Code.OK.intValue() == rc) {
FutureUtils.complete(promise, null);
- LOG.trace("Created path {}.", path);
+ if (LOG.isTraceEnabled()) {
Review Comment:
this is not useful
##########
stream/distributedlog/core/src/main/java/org/apache/distributedlog/lock/ZKSessionLock.java:
##########
@@ -770,7 +770,9 @@ public void execute() {
currentNode = name;
currentId =
getLockIdFromPath(currentNode);
- LOG.trace("{} received member id for
lock {}", lockId, currentId);
+ if (LOG.isTraceEnabled()) {
Review Comment:
this is not useful
##########
stream/distributedlog/core/src/main/java/org/apache/distributedlog/lock/ZKDistributedLock.java:
##########
@@ -181,7 +181,9 @@ void doAsyncAcquireWithSemaphore(final
CompletableFuture<ZKDistributedLock> acqu
void doAsyncAcquire(final CompletableFuture<ZKDistributedLock>
acquirePromise,
final long lockTimeout) {
- LOG.trace("Async Lock Acquire {}", lockPath);
+ if (LOG.isTraceEnabled()) {
Review Comment:
this is not useful
##########
stream/distributedlog/core/src/main/java/org/apache/distributedlog/BKAsyncLogReader.java:
##########
@@ -364,7 +364,9 @@ private boolean checkClosedOrInError(String operation) {
Throwable cause = lastExceptionUpdater.get(this);
if (null != cause) {
- LOG.trace("Cancelling pending reads");
+ if (LOG.isTraceEnabled()) {
Review Comment:
this is not useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
