lhotari commented on code in PR #3747:
URL: https://github.com/apache/bookkeeper/pull/3747#discussion_r1095615437
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:
##########
@@ -347,8 +347,8 @@ public void run() {
cbThreadPoolQueueSize.dec();
journalAddEntryStats.registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueTime),
TimeUnit.NANOSECONDS);
cb.writeComplete(0, ledgerId, entryId, null, ctx);
- recycle();
callbackTime.addLatency(MathUtils.elapsedNanos(startTime),
TimeUnit.NANOSECONDS);
+ recycle();
Review Comment:
@horizonzy This change wasn't mentioned in the PR description. Why was this
missing before? Was the recycling completely unused before? /cc @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
