wenbingshen commented on code in PR #3637:
URL: https://github.com/apache/bookkeeper/pull/3637#discussion_r1098609374
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java:
##########
@@ -599,20 +304,20 @@ synchronized Future<?> submitAuditTask() {
bookiesToBeAudited);
if (auditTask != null && auditTask.cancel(false)) {
auditTask = null;
- numDelayedBookieAuditsCancelled.inc();
+
auditorStats.getNumDelayedBookieAuditsCancelled().inc();
}
- startAudit(false);
+ auditorBookieCheckTask.startAudit(false);
bookiesToBeAudited.clear();
return;
}
if (auditTask == null) {
// if there is no scheduled audit, schedule one
auditTask = executor.schedule(() -> {
- startAudit(false);
+ auditorBookieCheckTask.startAudit(false);
Review Comment:
auditorBookieCheckTask is runnable, and scheduled operation is a complete
task execution. The runTask method is also a part of the task. startAudit is
only the execution of one of the methods, and does not represent a complete
scheduled task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
