hangc0276 opened a new pull request, #3791:
URL: https://github.com/apache/bookkeeper/pull/3791

   ### Motivation
   We have the following configurations from the DirectIO entry logger.
   ```
   dbStorage_directIOEntryLoggerTotalWriteBufferSizeMb
   dbStorage_directIOEntryLoggerTotalReadBufferSizeMb
   dbStorage_directIOEntryLoggerReadBufferSizeMb
   ```
   
   In fact, the units are bytes instead of bits. But from the first sight of 
the configuration name, users may be confused by the units, because we use `Mb` 
instead of `MB`.
   I suggest changing the configuration name suffix from `Mb` to `MB` to avoid 
confusing.
   
   ###  Modifications
   - Change `dbStorage_directIOEntryLoggerTotalWriteBufferSizeMb` to 
`dbStorage_directIOEntryLoggerTotalWriteBufferSizeMB`
   - Change `dbStorage_directIOEntryLoggerTotalReadBufferSizeMb` to 
`dbStorage_directIOEntryLoggerTotalReadBufferSizeMB`
   - Change `dbStorage_directIOEntryLoggerReadBufferSizeMb` to 
`dbStorage_directIOEntryLoggerReadBufferSizeMB`
   - Add documents in `conf/bk_server.conf`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to