zymap commented on code in PR #3789:
URL: https://github.com/apache/bookkeeper/pull/3789#discussion_r1113728208
##########
site3/website/docs/reference/config.md:
##########
@@ -156,6 +156,17 @@ The table below lists parameters that you can set to
configure bookies. All conf
| maximumNumberOfActiveEntryLogs | in entryLogPerLedger feature, this
specifies the maximum number of entrylogs that can be active at a given point
in time. If there are more number of active entryLogs then the
maximumNumberOfActiveEntryLogs then the entrylog will be evicted from the
cache. | 500 |
| entryLogPerLedgerCounterLimitsMultFactor | in
EntryLogManagerForEntryLogPerLedger, this config value specifies the metrics
cache size limits in multiples of entrylogMap cache size limits. | 10 |
+## DirectIO Entry log settings (Only support DbLedgerStorage)
+
+| Parameter | Description
| Default
+| ---------
|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
------- |
+| dbStorage_directIOEntryLogger | Enable/Disable directIO entry logger.
| false |
+| dbStorage_directIOEntryLoggerTotalWriteBufferSizeMb | Total write buffer
size in megabytes for all the entry directories. The write buffer size of each
entry directory needs to be divided by the number of entry directories. | 1/8
of max direct memory |
Review Comment:
```suggestion
| dbStorage_directIOEntryLoggerTotalWriteBufferSizeMB | Total write buffer
size in megabytes for all the entry directories. The write buffer size of each
entry directory needs to be divided by the number of entry directories. | 1/8
of max direct memory |
```
##########
site3/website/docs/reference/config.md:
##########
@@ -156,6 +156,17 @@ The table below lists parameters that you can set to
configure bookies. All conf
| maximumNumberOfActiveEntryLogs | in entryLogPerLedger feature, this
specifies the maximum number of entrylogs that can be active at a given point
in time. If there are more number of active entryLogs then the
maximumNumberOfActiveEntryLogs then the entrylog will be evicted from the
cache. | 500 |
| entryLogPerLedgerCounterLimitsMultFactor | in
EntryLogManagerForEntryLogPerLedger, this config value specifies the metrics
cache size limits in multiples of entrylogMap cache size limits. | 10 |
+## DirectIO Entry log settings (Only support DbLedgerStorage)
+
+| Parameter | Description
| Default
+| ---------
|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
------- |
+| dbStorage_directIOEntryLogger | Enable/Disable directIO entry logger.
| false |
+| dbStorage_directIOEntryLoggerTotalWriteBufferSizeMb | Total write buffer
size in megabytes for all the entry directories. The write buffer size of each
entry directory needs to be divided by the number of entry directories. | 1/8
of max direct memory |
+| dbStorage_directIOEntryLoggerTotalReadBufferSizeMb | Total read buffer size
in megabytes for all the entry directories. The read buffer size of each entry
directory needs to be divided by the number of entry directories. | 1/8 of
max direct memory |
Review Comment:
```suggestion
| dbStorage_directIOEntryLoggerTotalReadBufferSizeMB | Total read buffer
size in megabytes for all the entry directories. The read buffer size of each
entry directory needs to be divided by the number of entry directories. | 1/8
of max direct memory |
```
##########
site3/website/docs/reference/config.md:
##########
@@ -156,6 +156,17 @@ The table below lists parameters that you can set to
configure bookies. All conf
| maximumNumberOfActiveEntryLogs | in entryLogPerLedger feature, this
specifies the maximum number of entrylogs that can be active at a given point
in time. If there are more number of active entryLogs then the
maximumNumberOfActiveEntryLogs then the entrylog will be evicted from the
cache. | 500 |
| entryLogPerLedgerCounterLimitsMultFactor | in
EntryLogManagerForEntryLogPerLedger, this config value specifies the metrics
cache size limits in multiples of entrylogMap cache size limits. | 10 |
+## DirectIO Entry log settings (Only support DbLedgerStorage)
+
+| Parameter | Description
| Default
+| ---------
|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
------- |
+| dbStorage_directIOEntryLogger | Enable/Disable directIO entry logger.
| false |
+| dbStorage_directIOEntryLoggerTotalWriteBufferSizeMb | Total write buffer
size in megabytes for all the entry directories. The write buffer size of each
entry directory needs to be divided by the number of entry directories. | 1/8
of max direct memory |
+| dbStorage_directIOEntryLoggerTotalReadBufferSizeMb | Total read buffer size
in megabytes for all the entry directories. The read buffer size of each entry
directory needs to be divided by the number of entry directories. | 1/8 of
max direct memory |
+| dbStorage_directIOEntryLoggerReadBufferSizeMb | The buffer size, in
megabytes, for each direct reader to read data from the entry log file. An
entry log file will have only one direct reader. | 8 |
Review Comment:
```suggestion
| dbStorage_directIOEntryLoggerReadBufferSizeMB | The buffer size, in
megabytes, for each direct reader to read data from the entry log file. An
entry log file will have only one direct reader. | 8 |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
