zymap commented on code in PR #3799:
URL: https://github.com/apache/bookkeeper/pull/3799#discussion_r1115176417


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorElector.java:
##########
@@ -191,8 +192,14 @@ public void run() {
                         Thread.currentThread().interrupt();
                         submitShutdownTask();
                     } catch (Exception e) {
-                        LOG.error("Exception while performing auditor 
election", e);
-                        submitShutdownTask();
+                        if (e.getCause() instanceof 
KeeperException.ConnectionLossException

Review Comment:
   @dlg99 I saw it said connection loss is a recoverable exception.
   ```
   Recoverable errors: the disconnected event, connection timed out, and the 
connection loss exception are examples of recoverable errors
   ```
   
   The session expiration is a fatal error. We should re-create ZK client



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to