dlg99 commented on code in PR #3802:
URL: https://github.com/apache/bookkeeper/pull/3802#discussion_r1116064752
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java:
##########
@@ -369,6 +369,19 @@ public void compact(byte[] firstKey, byte[] lastKey)
throws IOException {
}
}
+ @Override
+ public void compact() throws IOException {
+ try {
+ long start = System.currentTimeMillis();
+ log.info("Starting RocksDB {} compact.", db.getName());
+ db.compactRange();
+ long end = System.currentTimeMillis();
+ log.info("RocksDB {} compact finished {} ms.", db.getName(), end -
start);
Review Comment:
can we get some rocksdb stats (space used etc) and output outcome (space
saved) as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
