hangc0276 commented on code in PR #3806:
URL: https://github.com/apache/bookkeeper/pull/3806#discussion_r1118001341
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java:
##########
@@ -358,7 +358,7 @@ public synchronized void writeComplete(int rc, long
ledgerId, long entryId, Book
} else {
LOG.warn("Failed to write entry ({}, {}) to bookie ({}, {}):
{}",
ledgerId, entryId, bookieIndex, addr,
BKException.getMessage(rc));
- lh.handleBookieFailure(ImmutableMap.of(bookieIndex, addr));
+ lh.executeOrdered(() ->
lh.handleBookieFailure(ImmutableMap.of(bookieIndex, addr)));
Review Comment:
We shouldn't change the thread here, it will delay the handleBookieFailure
process. Please check the failed test
`LedgerClose2Test#testMetadataChangedDuringClose`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
