hangc0276 commented on code in PR #3846:
URL: https://github.com/apache/bookkeeper/pull/3846#discussion_r1133741341
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java:
##########
@@ -229,6 +230,16 @@ protected void onAddRequestFinish() {
}
}
+ protected void onAddRequestFinishWithoutUnTrack() {
+ if (addsSemaphore != null) {
+ addsSemaphore.release();
+ }
+ }
+
+ protected void onAddRequestUnTrack() {
+ requestStats.untrackAddRequest();
+ }
Review Comment:
We batched the add requests, but each request callback one by one. So I
tracked N add requests at onAddRequestStart, but I should not call the
onAddRequestFinish after all the entries callback reached. We need to release
the addsSemaphore when one callback is reached and un-track the add requests
after all the entries callback reached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
