eolivelli commented on code in PR #3726:
URL: https://github.com/apache/bookkeeper/pull/3726#discussion_r1136654262


##########
pom.xml:
##########
@@ -696,6 +697,11 @@
         <artifactId>junit</artifactId>
         <version>${junit.version}</version>
       </dependency>
+      <dependency>
+        <groupId>com.tngtech.java</groupId>

Review Comment:
   usually it is better to not add such third party dependencies (tngtech ??) 
if not strictly needed
   
   in JUnit4 this is the way to do it
   https://github.com/junit-team/junit4/wiki/Parameterized-tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to