Reidddddd commented on PR #3813: URL: https://github.com/apache/bookkeeper/pull/3813#issuecomment-1469567126
The new fix is about the null check of `lhToNotify` it is assigned allocatedLh(LedgerHandle), and allocatedLh is only assigned in SimpleLedgerAllocator#completeAllocation, which means ledger allocation is completed. So if this is null, it means allocation doesn't happen, `shouldAllocate` should be true. If it is not null, set false and avoid orphan ledger allocation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
