horizonzy commented on code in PR #3876:
URL: https://github.com/apache/bookkeeper/pull/3876#discussion_r1145647939
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/HardLink.java:
##########
@@ -416,6 +471,19 @@ public static void createHardLink(File file, File linkName)
throw new IOException(
"invalid arguments to createHardLink: link name is null");
}
+
+ // if createLink available try first, else fall back to shell command.
+ if (CREATE_LINK_SUPPORTED.get()) {
Review Comment:
We can make the `CREATE_LINK_SUPPORTED` default value true, and remove the
test code.
If use createLink failed, change `CREATE_LINK_SUPPORTED` to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
