Apurva007 opened a new pull request, #3914: URL: https://github.com/apache/bookkeeper/pull/3914
Descriptions of the changes in this PR: This PR fixes the internal server error when the GC is triggered via the REST API. The reason this error occurs is because the code is trying to perform a String to boolean casting which is failing. The code change is to make this conversion work. ### Motivation Fixes #3845 ### Changes Modified the code to perform a safer string to boolean conversion when trying to find the values in the JSON payload. Also converted the map from a <String, Object> to <String, String>. Master Issue: #3845 > --- > In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit > checks for pull requests. A pull request can only be merged when it passes precommit checks. > > --- > Be sure to do all of the following to help us incorporate your contribution > quickly and easily: > > If this PR is a BookKeeper Proposal (BP): > > - [ ] Make sure the PR title is formatted like: > `<BP-#>: Description of bookkeeper proposal` > `e.g. BP-1: 64 bits ledger is support` > - [ ] Attach the master issue link in the description of this PR. > - [ ] Attach the google doc link if the BP is written in Google Doc. > > Otherwise: > > - [ ] Make sure the PR title is formatted like: > `<Issue #>: Description of pull request` > `e.g. Issue 123: Description ...` > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`. > - [ ] Replace `<Issue #>` in the title with the actual Issue number. > > --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
