rdhabalia opened a new pull request, #3924: URL: https://github.com/apache/bookkeeper/pull/3924
### Motivation It solves #3923 Right now, Bookie metrics (Prometheus) don't show if Bookie's sanity is passing or not. and with container-based Prometheus bookie metrics which are used for monitoring, it will be really useful if metrics also show the bookie sanity state so, Prometheus can automatically scrape the bookie sanity state and one can set up monitoring on it. Therefore, add support to include the bookie sanity state in the bookie metrics. For example: ``` URL: http://localhost:8000/metrics : # 1 shows bookie sanity is passing, 0 failed, -1 unknown bookie_SERVER_SANITY 1 ``` ### Changes - Add periodic task which performs sanity command on bookie and captures bookie sanity test periodically - Reuse the `SanityTestCommnad` for this purpose but SanityTestCommand has lot of blocking IO which can cause thread blocking for metrics collection. - Therefore, implement async method into `SanityTestCommnad` to avoid thread blocking and use it in metrics collection. Master Issue: #3923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
