wolfstudy opened a new pull request, #3925: URL: https://github.com/apache/bookkeeper/pull/3925
Descriptions of the changes in this PR: ### Motivation In the following code logic, the time unit we record is nanoseconds. https://github.com/apache/bookkeeper/blob/94e15b3dc0286de1dda1bd3989fd8b9de12e8d05/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java#L461-L467 When converting the time unit, we convert nanoseconds to microseconds, but the name of the variable here shows milliseconds, which is easy to cause misunderstanding. https://github.com/apache/bookkeeper/blob/94e15b3dc0286de1dda1bd3989fd8b9de12e8d05/stats/bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/DataSketchesOpStatsLogger.java#L67-L98 ### Changes Replace `valueMillis` with `valueMicros` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
