hangc0276 opened a new pull request, #3927:
URL: https://github.com/apache/bookkeeper/pull/3927

   ### Motivation
   When we get the metrics output from Prometheus, we found the metrics 
generated by the Prometheus client without type info, which will lead to some 
monitor integration systems can't parse the metrics
   ```
   jvm_gc_collection_seconds_count{gc="G1 Young Generation"} 4.0
   jvm_gc_collection_seconds_sum{gc="G1 Young Generation"} 2.287
   jvm_gc_collection_seconds_count{gc="G1 Old Generation"} 0.0
   jvm_gc_collection_seconds_sum{gc="G1 Old Generation"} 0.0
   jvm_memory_direct_bytes_max{} 2.147483648E9
   jvm_threads_current{} 136.0
   jvm_threads_daemon{} 18.0
   jvm_threads_peak{} 137.0
   jvm_threads_started_total{} 415.0
   jvm_threads_deadlocked{} 0.0
   jvm_threads_deadlocked_monitor{} 0.0
   process_cpu_seconds_total{} 740.860392
   process_start_time_seconds{} 1.681901598385E9
   process_open_fds{} 484.0
   process_max_fds{} 10240.0
   log4j2_appender_total{level="debug"} 0.0
   log4j2_appender_total{level="warn"} 20.0
   log4j2_appender_total{level="trace"} 0.0
   log4j2_appender_total{level="error"} 3.0
   log4j2_appender_total{level="fatal"} 0.0
   log4j2_appender_total{level="info"} 317.0
   caffeine_cache_hit_total{cache="bookies-racks-exists"} 0.0
   caffeine_cache_hit_total{cache="bookies-racks-children"} 0.0
   caffeine_cache_hit_total{cache="bookies-racks-data"} 2.0
   caffeine_cache_miss_total{cache="bookies-racks-exists"} 0.0
   caffeine_cache_miss_total{cache="bookies-racks-children"} 0.0
   caffeine_cache_miss_total{cache="bookies-racks-data"} 2.0
   caffeine_cache_requests_total{cache="bookies-racks-exists"} 0.0
   caffeine_cache_requests_total{cache="bookies-racks-children"} 0.0
   caffeine_cache_requests_total{cache="bookies-racks-data"} 4.0
   caffeine_cache_eviction_total{cache="bookies-racks-exists"} 0.0
   caffeine_cache_eviction_total{cache="bookies-racks-children"} 0.0
   ```
   
   ### Changes
   Write the metrics' type info to the output.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to