wenbingshen commented on code in PR #3965:
URL: https://github.com/apache/bookkeeper/pull/3965#discussion_r1205605995
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java:
##########
@@ -755,8 +759,9 @@ protected void extractMetaFromEntryLogs() throws
EntryLogMetadataMapException {
// ledgers anymore.
// We can remove this entry log file now.
LOG.info("Deleting entryLogId {} as it has no active
ledgers!", entryLogId);
- removeEntryLog(entryLogId);
-
gcStats.getReclaimedSpaceViaDeletes().addCount(entryLogMeta.getTotalSize());
+ if (removeEntryLog(entryLogId)) {
+
gcStats.getReclaimedSpaceViaDeletes().addCount(entryLogMeta.getTotalSize());
+ }
Review Comment:
make sense to me. I will add the stats for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
