gaozhangmin commented on PR #3980: URL: https://github.com/apache/bookkeeper/pull/3980#issuecomment-1579819179
> Thank for working on this. > > I think that the new test seems too much an "artifact": > > * it is full of reflective call > * full of mocks > > I wonder if the test would be useful in the future. > > Here we are testing some values in the internal representation, if in the future we would change that data structure this test may become useless or misleading. > > It would be better to have a test that reproduces a problem and that fails without the fix. > > which is the original problem that you was ? that the Bookie didn't call "force" ? or "flush" ? We can intercept those calls and verify that they are called the expected number of times Sure, I will add another test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
