XLzed commented on PR #3846: URL: https://github.com/apache/bookkeeper/pull/3846#issuecomment-1586077171
Hello! I'm a beginner of bookkeeper. Could you share more details about the benchmark like bk configuration and hardware enviroment? I want to use this change and learn the optimization method within it. But when I tried to reproduce the result of your benchmark, the results looked a little odd, the optimized version of protocolV2 performed about as well as the unoptimized version of protocolV3. What's the difference between V2 and V3？And why this optimization supports V2 only? Here's my hardware enviroment and benchmark results, thank you! server cmd：OPTS='-XX:MaxDirectMemorySize=10G -Xms40G -Xmx40G' ./bin/bookkeeper localbookie 1 client cmd：OPTS='-Dorg.apache.bookkeeper.conf.readsystemproperties=true -DuseV2WireProtocol=true' ./bookkeeper-benchmark/bin/benchmark writes -ensemble 1 -quorum 1 -ackQuorum 1 -ledgers 50 -throttle 10000  Before Change（useV2WireProtocol=false） <html> <body> <!--StartFragment--><div data-sabo-line="true" style="margin: 0px; white-space: pre;"> times | ops/sec | p95 latency | p99 latency -- | -- | -- | -- 1 | 212980 | 41.68268 | 44.85271 2 | 202530 | 42.99525 | 46.63221 3 | 212138 | 42.30779 | 45.08659 4 | 213154 | 42.22976 | 44.76916 5 | 198376 | 42.3406 | 47.08146 Avg | 207835.6 | 42.31122 | 45.68443 </div><div data-sabo-app-id="note.temu.team"></div><!--EndFragment--> </body> </html> Before Change (useV2WireProtocol=true) <html> <body> <!--StartFragment--><div data-sabo-line="true" style="margin: 0px; white-space: pre;"> times | ops/sec | p95 latency | p99 latency -- | -- | -- | -- 1 | 195363 | 46.08798 | 49.72923 2 | 198560 | 45.37565 | 48.83366 3 | 198490 | 45.53701 | 49.00147 4 | 202162 | 44.70965 | 48.1483 5 | 197736 | 45.71856 | 49.23503 Avg | 198462.2 | 45.48577 | 48.98954 </div><div data-sabo-app-id="note.temu.team"></div><!--EndFragment--> </body> </html> After Change (useV2WireProtocol=true) <html> <body> <!--StartFragment--><div data-sabo-line="true" style="margin: 0px; white-space: pre;"> times | ops/sec | p95 latency | p99 latency -- | -- | -- | -- 1 | 211978 | 41.49986 | 44.78894 2 | 216729 | 41.85365 | 44.18242 3 | 208047 | 42.2268 | 45.47032 4 | 204107 | 41.99345 | 46.13609 5 | 203803 | 42.82836 | 46.37437 Avg | 208932.8 | 42.08043 | 45.39043 </div><div data-sabo-app-id="note.temu.team"></div><!--EndFragment--> </body> </html> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
