horizonzy commented on PR #3977:
URL: https://github.com/apache/bookkeeper/pull/3977#issuecomment-1590619710

   > > I didn't notice this logic, can you help describe it?
   > 
   > When do rereplicate, if foundOpenFragments = true, it goto 
deferLedgerLockRelease(). The ledger would be fenced. And then wait 
openLedgerRereplicationGracePeriod(default 30s) to trigger rereplicate again. I 
guess we are able to recover opened ledger with this logic?
   > 
   > 
https://github.com/apache/bookkeeper/blob/c8c593ee6d3e1f8970bc90b4b6785ff405c81cc4/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java#L461-L463
   
   We'd better skip the last ensemble of the current ledger, as it may be 
writing data. Let's only copy the ensembles that have already been written 
before it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to