hangc0276 opened a new pull request, #3994:
URL: https://github.com/apache/bookkeeper/pull/3994
### Motivation
We use Slogger to support DirectIO Entrylogger and create the slogger
instance in DbLedgerStorage and passed down to DirectIOEntrylogger. However, in
the subclasses, we generate a new Slogger instance without setting the context,
which leads to the Slogger instance belonging to DbLedgerStorage or Slf4j. The
broker logs are as follows.
```
2023-06-19T15:21:56,518+0800 [main] INFO
org.apache.bookkeeper.bookie.storage.ldb.DbLedgerStorage -
ENTRYLOG_IDS_CANDIDATES_SELECTED
2023-06-19T15:21:56,561+0800 [main] INFO
org.apache.bookkeeper.slogger.slf4j.Slf4jSlogger
{directory=data/bookkeeper/ledgers/current, event=ENTRYLOGGER_CREATED,
maxCachedReaders=32, maxCachedReadersPerThread=4, maxFileSize=1073741824,
maxSaneEntrySize=5252620, perThreadBufferSize=33554432, readBufferSize=8388608,
singleWriteBufferSize=33554432, totalReadBufferSize=268435456,
totalWriteBufferSize=268435456} - ENTRYLOGGER_CREATED
```
Without the specific slogger instance name, it will be hard to configure a
specific class to enable KV logger configuration.
### Modification
Set the specific class context for each subclass slogger instance.
After this change, the broker logs are as follows.
```
2023-06-19T16:01:56,685+0800 [main] INFO
org.apache.bookkeeper.bookie.storage.directentrylogger.EntryLogIdsImpl
{dirs=[data/bookkeeper/ledgers/current], durationMs=0,
event=ENTRYLOG_IDS_CANDIDATES_SELECTED, maxId=21474836
47, nextId=0} - ENTRYLOG_IDS_CANDIDATES_SELECTED
2023-06-19T16:01:56,721+0800 [main] INFO
org.apache.bookkeeper.bookie.storage.directentrylogger.DirectEntryLogger
{directory=data/bookkeeper/ledgers/current, event=ENTRYLOGGER_CREATED,
maxCachedReaders=32, maxCachedReader
sPerThread=4, maxFileSize=1073741824, maxSaneEntrySize=5252620,
perThreadBufferSize=33554432, readBufferSize=8388608,
singleWriteBufferSize=33554432, totalReadBufferSize=268435456,
totalWriteBufferSize=268435456} - ENTRYLO
GGER_CREATED
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
