This is an automated email from the ASF dual-hosted git repository.
yong pushed a commit to branch branch-4.16
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/branch-4.16 by this push:
new 7fb5e9ac7f Fix issue with binary compatibility with older grpc
versions at runtime in the bookkeeper client. (#3997)
7fb5e9ac7f is described below
commit 7fb5e9ac7f84f2b446064fedd0fa036c3e2a85bb
Author: Lari Hotari <[email protected]>
AuthorDate: Wed Jun 21 06:09:39 2023 +0300
Fix issue with binary compatibility with older grpc versions at runtime in
the bookkeeper client. (#3997)
### Motivation
- grpc version was upgraded to 1.56.0 in #3992
- that breaks binary compatibility for DnsNameResolverProvider class
- see
https://github.com/grpc/grpc-java/commit/fcb5c54e4b82d354f42ced0121928fabce9ef53f#diff-b04e884de51ed12ff79482f600a2d4ec18e405ee189a4952ae35f4d2742b7160L50
### Changes
- make the field type NameResolverProvider instead of
DnsNameResolverProvider
- this prevents possible NoSuchMethodError errors about
DnsNameResolverProvider.newNameResolver method
(cherry picked from commit ffc8e8bec19e54dc76710c3de133401248f243d6)
---
.../apache/bookkeeper/common/resolver/ServiceNameResolverProvider.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/stream/common/src/main/java/org/apache/bookkeeper/common/resolver/ServiceNameResolverProvider.java
b/stream/common/src/main/java/org/apache/bookkeeper/common/resolver/ServiceNameResolverProvider.java
index 53e74891f9..a3a1b29a6b 100644
---
a/stream/common/src/main/java/org/apache/bookkeeper/common/resolver/ServiceNameResolverProvider.java
+++
b/stream/common/src/main/java/org/apache/bookkeeper/common/resolver/ServiceNameResolverProvider.java
@@ -40,7 +40,7 @@ import
org.apache.bookkeeper.common.util.SharedResourceManager.Resource;
@Slf4j
public final class ServiceNameResolverProvider extends
NameResolverFactoryProvider {
- private final DnsNameResolverProvider dnsProvider;
+ private final NameResolverProvider dnsProvider;
private final Resource<ExecutorService> executorResource;
public ServiceNameResolverProvider() {