horizonzy commented on code in PR #4013:
URL: https://github.com/apache/bookkeeper/pull/4013#discussion_r1251421856
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java:
##########
@@ -1061,14 +1061,15 @@ private Map<Integer, BookieId> getReplacementBookies(
}
}
return getReplacementBookiesByIndexes(
- lh, ensemble, bookieIndexesToRereplicate,
Optional.of(bookiesToRereplicate));
+ lh, ensemble, bookieIndexesToRereplicate,
Optional.of(bookiesToRereplicate), false);
Review Comment:
This method's entrance is `recoverBookieData`. The user specifies a
bookieSrc and then replaces the data of this bookie with another node. In this
scenario, the ledger of the bookie is not checked by ledgerChecker to determine
if any data is lost. Instead, the data of the bookie is directly replicated to
other bookies. If we set downgradeToSelf to `true`, the data may be copied to
bookieSrc itself instead of throwing an exception. I am not sure if this is a
good behavior for the user. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
