This is an automated email from the ASF dual-hosted git repository. chenhang pushed a commit to branch branch-4.14 in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
commit 4a87af4f2267b590b51e166c6f340b4593028bdc Author: wenbingshen <[email protected]> AuthorDate: Wed Apr 26 13:54:24 2023 +0800 recycle dropping read-write requests when various exceptions happened (#3912) (cherry picked from commit 3a9fe1b2874dd238766569895175ce2e9cabcabf) --- .../src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java | 1 + .../src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java index 7647e4afef..500aad894b 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java @@ -70,6 +70,7 @@ class ReadEntryProcessor extends PacketProcessorBase<ReadRequest> { LOG.debug("Dropping read request for closed channel: {}", channel); } requestProcessor.onReadRequestFinish(); + recycle(); return; } int errorCode = BookieProtocol.EOK; diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java index 0daa3814d2..44ad3e79db 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java @@ -67,6 +67,7 @@ class WriteEntryProcessor extends PacketProcessorBase<ParsedAddRequest> implemen requestProcessor.getRequestStats().getAddRequestStats()); request.release(); request.recycle(); + recycle(); return; } @@ -109,6 +110,7 @@ class WriteEntryProcessor extends PacketProcessorBase<ParsedAddRequest> implemen ResponseBuilder.buildErrorResponse(rc, request), requestProcessor.getRequestStats().getAddRequestStats()); request.recycle(); + recycle(); } }
