hangc0276 commented on code in PR #4020:
URL: https://github.com/apache/bookkeeper/pull/4020#discussion_r1264807400
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -1043,6 +1043,9 @@ public void checkTimeoutOnPendingOperations() {
if (timedOutOperations > 0) {
LOG.info("Timed-out {} operations to channel {} for {}",
timedOutOperations, channel, bookieId);
+ // In scenarios with message tampering, communication timeout can
lead to an unrecoverable state.
+ this.disconnect();
Review Comment:
If the timeout is not caused by message tampering, will the reconnect
operation cause any side effects?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
