zymap commented on code in PR #4032:
URL: https://github.com/apache/bookkeeper/pull/4032#discussion_r1267435525
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java:
##########
@@ -702,6 +704,48 @@ int runCmd(CommandLine cmdLine) throws Exception {
}
}
+ /**
+ * Command to delete a given ledger.
+ */
+ class MarkLedgerReplicatedCmd extends MyCommand {
+
+ MarkLedgerReplicatedCmd() {
+ super(CMD_MARKLEDGERREPLICATED);
+ opts.addOption("l", "ledgerid", true, "Ledger ID");
Review Comment:
It's better to provide a list or range option to allow given a group of
ledger id to mark. For example, we can use `,` to give a list of ledgers,
"1,2,3,4,5,6". We also can use a range to specify the ledger, "1...10".
This can avoid calling this command multiple times when there has many
ledgers that need to be marked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
