lifepuzzlefun commented on code in PR #4023:
URL: https://github.com/apache/bookkeeper/pull/4023#discussion_r1285377355
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java:
##########
@@ -968,12 +968,18 @@ public void scanEntryLog(long entryLogId, EntryLogScanner
scanner) throws IOExce
// Buffer where to read the entrySize (4 bytes) and the ledgerId (8
bytes)
ByteBuf headerBuffer = Unpooled.buffer(4 + 8);
BufferedReadChannel bc;
+ boolean throwExceptionWhenGetChannel = false;
// Get the BufferedChannel for the current entry log file
try {
bc = getChannelForLogId(entryLogId);
} catch (IOException e) {
LOG.warn("Failed to get channel to scan entry log: " + entryLogId
+ ".log");
+ throwExceptionWhenGetChannel = true;
Review Comment:
Thanks for review. I think the code function is the same. release resource
in finally code block is more like the java style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
