horizonzy commented on code in PR #4062:
URL: https://github.com/apache/bookkeeper/pull/4062#discussion_r1309864564
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -1318,4 +1322,11 @@ private BookieNode
replaceToAdherePlacementPolicyInternal(
}
throw new BKNotEnoughBookiesException();
}
+
+ protected String getLocalRack(BookieNode node) {
+ if (null == node || null == node.getAddr()) {
+ return UNKNOWN_RACK;
+ }
+ return node.getNetworkLocation();
Review Comment:
If the network location is `/default-rack`, shall we think of it as
UNKNOWN_RACK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
