lhotari commented on PR #4067: URL: https://github.com/apache/bookkeeper/pull/4067#issuecomment-1702951800
btw. It might be the case that the previous code is fine. The problem with the old code is that it is cryptic. In the original code, `signSafeMod` function's name is misleading. In the cases where the item takes 2 or 4 elements, there's a bitwise shift to left to multiply by 2 (`<< 1`) or 4 (`<< 2`). I doubt that using bitwise operations to optimize the speed of execution is worthwhile in Java code. It should be left to the compiler to do such optimizations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
