horizonzy commented on PR #3433:
URL: https://github.com/apache/bookkeeper/pull/3433#issuecomment-1730845387

   > I'm not sure if I am missing something because this is a year old merged 
bug .. but updating a cluster from 4.15.4 to 4.16.3 (both using the dockerhub 
official images ) I still get this incompatibility issue , shouldn't the cookie 
be compatible and get updated once the 4.16+ bookie starts ?
   > 
   > ```
   > 2023-09-21T09:36:00,280 - ERROR - [main:Main@218] - Failed to build bookie 
server
   > org.apache.bookkeeper.bookie.BookieException$InvalidCookieException: 
Cookie [5
   > bookieHost: "bk1"
   > journalDir: "/data/bookkeeper/journal"
   > ledgerDirs: "1\t/data/bookkeeper/ledgers"
   > instanceId: "e44f080b-a6ba-4b5e-97f0-0a0303bfd295"
   > indexDirs: "1\t/data/bookkeeper/index"
   > ] is not matching with [5
   > bookieHost: "bk1"
   > journalDir: "/data/bookkeeper/journal"
   > ledgerDirs: "1\t/data/bookkeeper/ledgers"
   > instanceId: "e44f080b-a6ba-4b5e-97f0-0a0303bfd295"
   > ```
   > 
   > a fast check on the code and the problem maybe was because I've used a 
specified indexDirs instead of the default (ledgerdir) one ? but the code seems 
to assume that if the cookie is blank then it's the ledgerDirs ( and shouldn't 
assume that because can be configured differently in the configuration )
   > 
   > 
https://github.com/StevenLuMT/bookkeeper/blob/905d317c5ab6e700aa3195259c274b55a70540c5/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Cookie.java#L142-L143
   > 
   > as note for others in the same situation my workaround has been to do a 
rolling update with the reset cookie `bin/bookkeeper shell bookieformat 
-deleteCookie ` on each bookie
   
   Yes, it's indeed a problem. If the cookie doesn't has indexDirs,  we 
shouldn't consider `ledgerDirs` as its value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to